Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transfer): add test #925

Merged
merged 1 commit into from
Aug 20, 2021
Merged

test(transfer): add test #925

merged 1 commit into from
Aug 20, 2021

Conversation

XieZongChen
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Aug 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/6io3SFm9NywosZWzksenUNZg79Si
✅ Preview: https://naive-ui-git-fork-amadeus711-test-add-transfer-test-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #925 (b7bbaff) into main (e9fb97e) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   44.44%   44.64%   +0.20%     
==========================================
  Files         509      509              
  Lines       12459    12459              
  Branches     3501     3501              
==========================================
+ Hits         5537     5562      +25     
+ Misses       5914     5896      -18     
+ Partials     1008     1001       -7     
Impacted Files Coverage Δ
src/input/src/Input.tsx 44.91% <0.00%> (+1.31%) ⬆️
src/transfer/src/Transfer.tsx 40.84% <0.00%> (+5.63%) ⬆️
src/transfer/src/use-transfer-data.ts 65.21% <0.00%> (+14.49%) ⬆️
src/_internal/icons/Search.tsx 100.00% <0.00%> (+100.00%) ⬆️
src/transfer/src/TransferFilter.tsx 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fb97e...b7bbaff. Read the comment docs.

@XieZongChen XieZongChen merged commit efa6484 into tusen-ai:main Aug 20, 2021
Copy link
Collaborator

@07akioni 07akioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change sleep(300)

Comment on lines +35 to +37
await wrapper.find('input').setValue('1')
await sleep(300)
expect(onFilter).toHaveBeenCalled()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why sleep(300)?

Use a proper way.

rhengles pushed a commit to arijs/naive-ui that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants