feat(message provider): add placement prop #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Talljack
reviewed
Aug 12, 2021
| @@ -56,6 +56,7 @@ multiple-line | |||
| | closable | `boolean` | All messages whether to show close icon. | | |||
| | duration | `number` | `3000` | All messages's default duration. | | |||
| | max | `number` | `undefined` | Limit the number of message to display. | | |||
| | placement | `top \| top-left \| top-right \| bottom \| bottom-left \| bottom-right ` | `top` | All messages placement | | |||
There was a problem hiding this comment.
Suggested change
| | placement | `top \| top-left \| top-right \| bottom \| bottom-left \| bottom-right ` | `top` | All messages placement | | |
| | placement | `top \| top-left \| top-right \| bottom \| bottom-left \| bottom-right ` | `top` | All message's placement. | |
src/message/src/Message.tsx
Outdated
Comment on lines
126
to
131
| style={{ | ||
| ...(cssVars as CSSProperties), | ||
| [this.placement.startsWith('top') ? 'top' : 'bottom']: '12px', | ||
| left: this.placement.endsWith('left') ? '12px' : '', | ||
| right: this.placement.endsWith('right') ? '12px' : '' | ||
| }} |
There was a problem hiding this comment.
我刚开始放到container上，有些样式问题
doom-9-zz
changed the title
07akioni
reviewed
Aug 12, 2021
src/message/src/styles/index.cssr.ts
Outdated
| @@ -26,6 +26,7 @@ import fadeInHeightExpand from '../../../_styles/transitions/fade-in-height-expa | |||
| // --border-radius | |||
| export default c([ | |||
| cB('message-wrapper', ` | |||
| position: fixed; | |||
There was a problem hiding this comment.
不能这么弄，若干这样没办法叠加了。
我们需要改的是 container 的样式，不是 message 自身。
doom-9-zz
force-pushed
the
feat(message-provider)-add-placement-prop
branch
from
4745e28 to
4c5c589
Compare
Talljack
reviewed
Aug 13, 2021
CHANGELOG.en-US.md
Outdated
Comment on lines
7
to
8
| - `n-message-provider` add `container-style` prop | ||
| - `n-message-provider` add `placement` prop. |
There was a problem hiding this comment.
Suggested change
| - `n-message-provider` add `container-style` prop | |
| - `n-message-provider` add `placement` prop. | |
| - `n-message-provider` add `container-style` prop. | |
| - `n-message-provider` add `placement` prop. |
| @@ -21,10 +21,10 @@ import { defineComponent } from 'vue' | |||
|
|
|||
| // content | |||
| export default defineComponent({ | |||
| setup () { | |||
| setup() { | |||
There was a problem hiding this comment.
please use eslint to format it
There was a problem hiding this comment.
这个格式化是commit触发的钩子
|
现在 Message 本体的动画有问题，从上往下的时候，折叠过程中 message 按照上边缘对齐的，所以 message 的位置看起来不会有很大的 offset。但是如果从下到上，message 的动画还是按照上边缘对齐，就会往下走了。 |
确实，我处理下 |
doom-9-zz
commented
Aug 14, 2021
| @@ -106,10 +106,11 @@ export default defineComponent({ | |||
| '--line-height': lineHeight, | |||
| '--border-radius': borderRadius | |||
| } | |||
| }) | |||
| }), | |||
| placement: messageProviderProps.placement | |||
There was a problem hiding this comment.
不用，先不支持单个 message 的位置。有需求我们在加，那样会比较复杂，需要每个 placement 储存一个数组。
const messages = {
top: [],
bottom: [],
...
}
我们先暂时不做
07akioni
reviewed
Aug 15, 2021
| @@ -150,7 +156,7 @@ export default defineComponent({ | |||
| } | |||
| }) | |||
|
|
|||
| function createIconVNode ( | |||
| function createIconVNode( | |||
rhengles
pushed a commit
to arijs/naive-ui
that referenced
this pull request
Oct 20, 2021
* feat:n-input Support hidden password * feat(form): support require-mark-placement(tusen-ai#171) * Revert "feat(form): support require-mark-placement(tusen-ai#171)" This reverts commit 0627777. * Revert "feat:n-input Support hidden password" This reverts commit ea64917. * feat(message provider): add placement prop(wip) * feat(message provider): add placement prop * feat: add demo * feat: fix demo code * feat: fix code * feat: fix code * Update CHANGELOG.en-US.md * feat: fix style code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.