Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add touch events support for slider #73

Merged
merged 5 commits into from
Jun 11, 2021

Conversation

s-r-x
Copy link
Contributor

@s-r-x s-r-x commented Jun 11, 2021

Hello ^-^. Right now the Slider component doesn't work well on mobile devices, because it doesn't react to touchstart/touchmove and touchend events. This pr will fix it.

@vercel
Copy link

vercel bot commented Jun 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/DEr13uCPnDGpfPrYiJgC4KxDtUkt
✅ Preview: https://naive-ui-git-fork-s-r-x-fix-slider-touch-events-tusimple.vercel.app

@vercel vercel bot temporarily deployed to Preview June 11, 2021 07:21 Inactive
Copy link
Collaborator

@07akioni 07akioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

Please add changlog to /CHANGELOG.zh-CN.md & /CHANGELOG.en-US.md

Using either English or Chinese is OK.

@vercel vercel bot temporarily deployed to Preview June 11, 2021 08:28 Inactive
CHANGELOG.en-US.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 11, 2021 08:35 Inactive
CHANGELOG.en-US.md Outdated Show resolved Hide resolved
CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 11, 2021 09:11 Inactive
@07akioni 07akioni merged commit 75880dc into tusen-ai:main Jun 11, 2021
@lhf6623
Copy link

lhf6623 commented Jul 2, 2021

能否添加动画

@07akioni
Copy link
Collaborator

07akioni commented Jul 2, 2021

能否添加动画

什么动画?

@lhf6623
Copy link

lhf6623 commented Jul 2, 2021

能否添加动画

什么动画?

滑块从 0 到 100 需要一个缓慢的过渡动画,我自己加了以下代码,提示文字位置有 bug
:deep(.n-slider-rail__fill), :deep(.n-slider-handle) { transition: left 0.3s, transform 0.3s, width 0.3s, background-color 0.3s var(--bezier) !important; }

@07akioni
Copy link
Collaborator

07akioni commented Jul 2, 2021

能否添加动画

什么动画?

滑块从 0 到 100 需要一个缓慢的过渡动画,我自己加了以下代码,提示文字位置有 bug
:deep(.n-slider-rail__fill), :deep(.n-slider-handle) { transition: left 0.3s, transform 0.3s, width 0.3s, background-color 0.3s var(--bezier) !important; }

暂时没有增加的打算,这个不是无级的滚动。

@lhf6623
Copy link

lhf6623 commented Jul 2, 2021

能否添加动画

什么动画?

滑块从 0 到 100 需要一个缓慢的过渡动画,我自己加了以下代码,提示文字位置有 bug
:deep(.n-slider-rail__fill), :deep(.n-slider-handle) { transition: left 0.3s, transform 0.3s, width 0.3s, background-color 0.3s var(--bezier) !important; }

暂时没有增加的打算,这个不是无级的滚动。

行吧,有把提示文字去掉的打算吗?
OK, do you have any plans to remove the prompt text?

@lhf6623
Copy link

lhf6623 commented Jul 2, 2021

给一个选项隐藏/显示
Give an option to hide / show

@07akioni
Copy link
Collaborator

07akioni commented Jul 2, 2021

给一个选项隐藏/显示
Give an option to hide / show

你的意思是不显示 tooltip?这个没问题,提一个 feature request 吧

@lhf6623
Copy link

lhf6623 commented Jul 2, 2021

给一个选项隐藏/显示
Give an option to hide / show

你的意思是不显示 tooltip?这个没问题,提一个 feature request 吧

老哥, feature request 这个是啥,我不会啊

@lhf6623
Copy link

lhf6623 commented Jul 2, 2021

给一个选项隐藏/显示
Give an option to hide / show

你的意思是不显示 tooltip?这个没问题,提一个 feature request 吧

#362 你看看这样对不对,第一次提交issues

@07akioni
Copy link
Collaborator

07akioni commented Jul 2, 2021

#362

可以

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants