-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add touch events support for slider #73
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/DEr13uCPnDGpfPrYiJgC4KxDtUkt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
Please add changlog to /CHANGELOG.zh-CN.md & /CHANGELOG.en-US.md
Using either English or Chinese is OK.
能否添加动画 |
什么动画? |
滑块从 0 到 100 需要一个缓慢的过渡动画,我自己加了以下代码,提示文字位置有 bug |
暂时没有增加的打算,这个不是无级的滚动。 |
行吧,有把提示文字去掉的打算吗? |
给一个选项隐藏/显示 |
你的意思是不显示 tooltip?这个没问题,提一个 feature request 吧 |
老哥, feature request 这个是啥,我不会啊 |
#362 你看看这样对不对,第一次提交issues |
可以 |
Hello ^-^. Right now the Slider component doesn't work well on mobile devices, because it doesn't react to touchstart/touchmove and touchend events. This pr will fix it.