Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useDialog): add onMaskClick prop #561

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Conversation

Talljack
Copy link
Contributor

close #419

@vercel
Copy link

vercel bot commented Jul 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/3xevLNawRxVwELykJ4ynQxfnyDEG
✅ Preview: https://naive-ui-git-fork-talljack-dialogevent-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #561 (957dc37) into main (7991169) will increase coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   37.67%   37.73%   +0.06%     
==========================================
  Files         507      507              
  Lines       12235    12242       +7     
  Branches     3388     3391       +3     
==========================================
+ Hits         4610     4620      +10     
+ Misses       6757     6752       -5     
- Partials      868      870       +2     
Impacted Files Coverage Δ
src/modal/src/Modal.tsx 29.16% <66.66%> (+4.52%) ⬆️
src/dialog/src/DialogEnvironment.tsx 35.48% <100.00%> (+13.26%) ⬆️
src/modal/src/BodyWrapper.tsx 29.03% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7991169...957dc37. Read the comment docs.

Copy link
Collaborator

@07akioni 07akioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

蒙层

这个东西一般叫遮罩

@07akioni
Copy link
Collaborator

我感觉 maskClosable 应该够用了,需要这个属性吗?

@Talljack
Copy link
Contributor Author

有用户提出来了,有可能会用到的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add an event for when the user clicks on the overlay/mask of a dialog
2 participants