Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-table): add expanded-row-remain-sticky option #3488

Merged
merged 6 commits into from
Aug 18, 2022
Merged

feat(data-table): add expanded-row-remain-sticky option #3488

merged 6 commits into from
Aug 18, 2022

Conversation

equt
Copy link
Collaborator

@equt equt commented Aug 11, 2022

close #3485

@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
naive-ui ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 1:06AM (UTC)

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3488 (23ecd62) into main (1ed0aec) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3488      +/-   ##
==========================================
- Coverage   63.03%   63.03%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       21877    21878       +1     
  Branches     5695     5696       +1     
==========================================
  Hits        13790    13790              
  Misses       6601     6601              
- Partials     1486     1487       +1     
Impacted Files Coverage Δ
src/data-table/src/TableParts/Body.tsx 62.31% <0.00%> (-0.23%) ⬇️
src/data-table/src/styles/index.cssr.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Sepush
Copy link
Collaborator

Sepush commented Aug 11, 2022

补一下 changelog

@equt
Copy link
Collaborator Author

equt commented Aug 12, 2022

要不要加个什么 expand-sticky 之类的 option?还是说直接放 breaking changes 里

@equt equt requested a review from 07akioni August 12, 2022 04:52
@07akioni
Copy link
Collaborator

要不要加个什么 expand-sticky 之类的 option?还是说直接放 breaking changes 里

加一个吧

@equt equt changed the title feat(data-table): make expand content sticky by default feat(data-table): add expanded-row-remain-sticky option Aug 15, 2022
@equt equt removed the request for review from 07akioni August 17, 2022 12:39
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #3488 (2b97ddd) into main (60015b1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3488      +/-   ##
==========================================
- Coverage   62.99%   62.99%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       21923    21925       +2     
  Branches     5719     5720       +1     
==========================================
+ Hits        13811    13812       +1     
  Misses       6623     6623              
- Partials     1489     1490       +1     
Impacted Files Coverage Δ
src/data-table/src/DataTable.tsx 70.93% <ø> (ø)
src/data-table/src/TableParts/Body.tsx 62.98% <0.00%> (-0.23%) ⬇️
src/data-table/src/interface.ts 100.00% <ø> (ø)
src/data-table/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/data-table/src/use-expand.ts 61.76% <100.00%> (+1.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@equt equt merged commit 9055caa into tusen-ai:main Aug 18, 2022
@equt equt deleted the #3485 branch August 18, 2022 01:24
@07akioni
Copy link
Collaborator

07akioni commented Aug 18, 2022

343d032

我重新写了一下,body width 那块说明你对渲染性能还不够熟悉,可以研究一下

你那么写的话所有的情况只要 bodywidth 变了组件就会重新渲染

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option to Fix Data Table Expanded Cell When Vertical Scrolling Enabled
4 participants