Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): doesn't scroll to selected item when menu is opened #348

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

07akioni
Copy link
Collaborator

@07akioni 07akioni commented Jul 1, 2021

fix #346

@vercel
Copy link

vercel bot commented Jul 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/fPSuAZWpYRxDcN7nFQyP8GkFANzc
✅ Preview: https://naive-ui-git-fix-select-scroll-tusimple.vercel.app

@07akioni 07akioni temporarily deployed to test July 1, 2021 17:26 Inactive
@07akioni 07akioni temporarily deployed to test July 1, 2021 17:26 Inactive
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #348 (ef2ba19) into main (8564f95) will increase coverage by 0.10%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   33.74%   33.85%   +0.10%     
==========================================
  Files         507      507              
  Lines       12091    12094       +3     
  Branches     3303     3302       -1     
==========================================
+ Hits         4080     4094      +14     
+ Misses       7234     7214      -20     
- Partials      777      786       +9     
Impacted Files Coverage Δ
src/_internal/select-menu/src/SelectMenu.tsx 46.90% <69.23%> (+5.99%) ⬆️
src/scrollbar/src/ScrollBar.tsx 36.66% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8564f95...ef2ba19. Read the comment docs.

@07akioni 07akioni merged commit 30d0299 into main Jul 1, 2021
@07akioni 07akioni deleted the fix-select-scroll branch October 27, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

n-select selected option not in view when set procedurally in the model
1 participant