feat: scroll to end input element #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Innei <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Innei <[email protected]>
|
直接给个 srollTo 吧，对 input 和 textarea 都生效，toend 太局限了 |
Signed-off-by: Innei <[email protected]>
Signed-off-by: Innei <[email protected]>
07akioni
reviewed
Jul 18, 2022
src/input/src/Input.tsx
Outdated
Comment on lines
709
to
724
| function scrollToEnd (animated = true): void { | ||
| const { value: textareaEl } = textareaElRef | ||
| if (!textareaEl) { | ||
| return | ||
| } | ||
|
|
||
| const { scrollHeight, scrollTop, clientHeight } = textareaEl | ||
| const end = scrollHeight - clientHeight | ||
| if (end === scrollTop) { | ||
| return | ||
| } | ||
| scrollTo({ | ||
| top: end, | ||
| behavior: animated ? 'smooth' : 'auto' | ||
| }) | ||
| } |
Signed-off-by: Innei <[email protected]>
07akioni
reviewed
Jul 19, 2022
src/input/demos/zhCN/focus.demo.vue
Outdated
| handleScrollEnd () { | ||
| inputInstRef.value?.scrollTo({ | ||
| behavior: 'smooth', | ||
| top: inputInstRef.value?.textareaElRef?.scrollHeight |
07akioni
reviewed
Jul 19, 2022
07akioni
reviewed
Jul 19, 2022
07akioni
reviewed
Jul 19, 2022
07akioni
reviewed
Jul 19, 2022
07akioni
reviewed
Jul 19, 2022
07akioni
reviewed
Jul 19, 2022
07akioni
reviewed
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Innei [email protected]
closes #3280