fix(Carousel): simple code and fix the bug #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
07akioni
reviewed
Jul 5, 2022
| duplicatedable?: boolean | ||
| ): number { | ||
| return duplicatedable && total > 3 ? total - 2 : total | ||
| } |
There was a problem hiding this comment.
它里面只有 duplicated 的逻辑，要改为 shared 吗
There was a problem hiding this comment.
我以为这个是重复逻辑放在这，如果就是普通的工具函数不如放到 utils 里面
07akioni
reviewed
Jul 5, 2022
src/carousel/src/CarouselItem.tsx
Outdated
| import { useConfig } from '../../_mixins' | ||
| import { throwError } from '../../_utils' | ||
| import { carouselMethodsInjectionKey } from './interface' | ||
| import type { VNode } from 'vue' |
07akioni
reviewed
Jul 5, 2022
| @@ -0,0 +1,12 @@ | |||
| let supportsPassive = false | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## main #3235 +/- ##
==========================================
+ Coverage 63.14% 63.19% +0.04%
==========================================
Files 1020 1022 +2
Lines 21367 21360 -7
Branches 5575 5569 -6
==========================================
+ Hits 13493 13498 +5
+ Misses 6427 6413 -14
- Partials 1447 1449 +2
Continue to review full report at Codecov.
|
nooooooom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3227, #3106, #3078.