Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #3096 +/- ##
==========================================
- Coverage 63.21% 63.10% -0.11%
==========================================
Files 1012 1010 -2
Lines 20987 20988 +1
Branches 5460 5465 +5
==========================================
- Hits 13267 13245 -22
- Misses 6303 6331 +28
+ Partials 1417 1412 -5
Continue to review full report at Codecov.
|
07akioni
reviewed
Jun 14, 2022
| }) | ||
|
|
||
| onBeforeUnmount(() => { | ||
| if (props.lazy) { |
There was a problem hiding this comment.
如果一开始 lazy 最后不 lazy 就泄漏了
07akioni
reviewed
Jun 14, 2022
src/image/src/utils.ts
Outdated
| if (imgObserver === null) { | ||
| imgObserverOptions = { | ||
| root: document.querySelector(root), | ||
| threshold: 0.1 |
07akioni
reviewed
Jun 14, 2022
src/image/src/utils.ts
Outdated
|
|
||
| export const imgObserverHandler: ( | ||
| el: HTMLImageElement | null, | ||
| unobserve: boolean, |
07akioni
reviewed
Jun 14, 2022
src/image/src/Image.tsx
Outdated
| @@ -121,6 +143,7 @@ export default defineComponent({ | |||
| style={[imgProps.style || '', { objectFit: this.objectFit }]} | |||
| data-error={this.showError} | |||
| data-preview-src={this.previewSrc || this.src} | |||
| data-src={this.showError ? this.fallbackSrc : this.src || imgProps.src} | |||
There was a problem hiding this comment.
这块和上面那块看起来整体有点乱，能不能抽到 setup 算一下
|
整体逻辑看起来挺合理的 |
doom-9-zz
force-pushed
the
feat(image)-支持懒加载
branch
from
cbd0619 to
e757830
Compare
Closed
|
学习学习 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这种方案行不行