feat(code): add word-wrap prop
#2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sepush <[email protected]>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/3TLaHUcQ4bW2pZCtFFRbq6gvKvyk |
07akioni
reviewed
Jan 7, 2022
Comment on lines
18
to
19
| <p class="n-p" data-v-79af885b="" style="--n-bezier:cubic-bezier(0.4, 0, 0.2, 1); --n-font-size:14px; --n-line-height:1.6; --n-text-color:rgb(51, 54, 57); font-size: 16px; margin-top: 0px; margin-bottom: 0px;">还是得再学习一个</p> | ||
| ` |
There was a problem hiding this comment.
这代码感觉有点迷惑性啊，换一个更直观的？某种编程语言的
07akioni
reviewed
Jan 7, 2022
| @@ -0,0 +1,23 @@ | |||
| <markdown> | |||
| # 软换行 | |||
| </markdown> | |||
07akioni
reviewed
Jan 7, 2022
src/code/src/styles/index.cssr.ts
Outdated
| @@ -23,6 +23,7 @@ export default c([ | |||
| c('pre', ` | |||
| margin: 0; | |||
| font-family: inherit; | |||
| white-space: pre-wrap; | |||
There was a problem hiding this comment.
这个需要加一个新的属性，叫 word-wrap，默认关闭。
不换行才是默认的需求。
换行需要加属性。
Signed-off-by: Sepush <[email protected]>
07akioni
reviewed
Jan 7, 2022
| @@ -23,7 +24,7 @@ export default c([ | |||
| c('pre', ` | |||
| margin: 0; | |||
| font-family: inherit; | |||
| white-space: pre-wrap; | |||
| white-space: var(--n-word-wrap); | |||
There was a problem hiding this comment.
这个别通过变量实现，直接加个类就行，这个变量对用户没有任何调整的价值
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sepush [email protected]
add
word-wrappropclose #2111