Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(dropdown) transition shifts in cascade dropdown with anchor option #1620

Conversation

doom-9-zz
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/68BDBUsL4AkAt3tzWr9ptBi6LVcC
✅ Preview: https://naive-ui-git-fork-doom-9-fixdropdown-transition-65848a-tusimple.vercel.app

@doom-9-zz
Copy link
Contributor Author

close #1600

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1620 (8f219c7) into main (66f4e2d) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1620   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         885      885           
  Lines       17057    17064    +7     
  Branches     4023     4024    +1     
=======================================
+ Hits        10997    11002    +5     
- Misses       5312     5314    +2     
  Partials      748      748           
Impacted Files Coverage Δ
src/dropdown/src/utils.ts 87.50% <71.42%> (-12.50%) ⬇️
src/dropdown/src/DropdownOption.tsx 81.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f4e2d...8f219c7. Read the comment docs.

@XieZongChen XieZongChen linked an issue Nov 19, 2021 that may be closed by this pull request
@07akioni 07akioni merged commit d267b3c into tusen-ai:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition shifts in cascade dropdown with anchor option
3 participants