Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input):input-props override the props #1576

Merged
merged 2 commits into from
Nov 14, 2021
Merged

fix(input):input-props override the props #1576

merged 2 commits into from
Nov 14, 2021

Conversation

Sepush
Copy link
Collaborator

@Sepush Sepush commented Nov 12, 2021

fix input-props does not override properly
add some doc about input-pops
add warning in API table
close #1553

@vercel
Copy link

vercel bot commented Nov 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/FA1TrZFm55xmNjzBuSLAiSmyoUUv
✅ Preview: https://naive-ui-git-fork-sepush-input-tusimple.vercel.app

@Sepush Sepush changed the title Input fix(TuSimple#1553):input-props override the props Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1576 (dd74004) into main (792fc28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1576   +/-   ##
=======================================
  Coverage   64.33%   64.33%           
=======================================
  Files         884      884           
  Lines       17111    17111           
  Branches     4043     4043           
=======================================
  Hits        11009    11009           
  Misses       5369     5369           
  Partials      733      733           
Impacted Files Coverage Δ
src/input/src/Input.tsx 55.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792fc28...dd74004. Read the comment docs.

@XieZongChen
Copy link
Collaborator

In the scope field of the commit message, please fill in the component.

@Sepush Sepush changed the title fix(TuSimple#1553):input-props override the props fix(input):input-props override the props Nov 13, 2021
@Sepush
Copy link
Collaborator Author

Sepush commented Nov 13, 2021

In the scope field of the commit message, please fill in the component.

done

@07akioni 07akioni merged commit 15b2145 into tusen-ai:main Nov 14, 2021
@Sepush Sepush deleted the input branch November 15, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input enhancements - Supports other native input types
3 participants