feat(page-header): support rtl #1154
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/29yn8zEZ3n1aoyhfD7uucUzcWnxD |
Codecov Report
@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 49.77% 49.78%
=======================================
Files 514 514
Lines 12716 12718 +2
Branches 3600 3601 +1
=======================================
+ Hits 6330 6332 +2
Misses 5298 5298
Partials 1088 1088
Continue to review full report at Codecov.
|
src/page-header/src/PageHeader.tsx
Outdated
| [ | ||
| { | ||
| [`${mergedClsPrefix}-page-header-header--rtl`]: | ||
| this.rtlEnabled | ||
| } | ||
| ] |
There was a problem hiding this comment.
| [ | |
| { | |
| [`${mergedClsPrefix}-page-header-header--rtl`]: | |
| this.rtlEnabled | |
| } | |
| ] | |
| this.rtlEnabled && `${mergedClsPrefix}-page-header-header--rtl` |
src/page-header/src/PageHeader.tsx
Outdated
| [ | ||
| { | ||
| [`${mergedClsPrefix}-page-header--rtl`]: this.rtlEnabled | ||
| } | ||
| ] |
There was a problem hiding this comment.
| [ | |
| { | |
| [`${mergedClsPrefix}-page-header--rtl`]: this.rtlEnabled | |
| } | |
| ] | |
| this.rtlEnabled && `${mergedClsPrefix}-page-header--rtl` |
| cB('page-header-header', [ | ||
| cM('rtl', ` | ||
| direction: rtl; | ||
| `) | ||
| ]), | ||
| cB('page-header', [ | ||
| cM('rtl', ` | ||
| direction: rtl; | ||
| `) | ||
| ]), | ||
| cB('page-header-content', [ | ||
| cM('rtl', ` | ||
| direction: rtl; | ||
| `) | ||
| ]), | ||
| cB('page-header-footer', [ | ||
| cM('rtl', ` | ||
| direction: rtl; | ||
| `) | ||
| ]) |
There was a problem hiding this comment.
感觉 RTL 的类可以直接加在 page-header 的 DOM 上，没必要的话不加特别多的类
src/page-header/src/PageHeader.tsx
Outdated
| [ | ||
| { | ||
| [`${mergedClsPrefix}-page-header-content--rtl`]: | ||
| this.rtlEnabled | ||
| } | ||
| ] |
There was a problem hiding this comment.
感觉 RTL 的类可以直接加在 page-header 的 DOM 上，没必要的话不加特别多的类
| @@ -0,0 +1,94 @@ | |||
| # Rtl Debug | |||
There was a problem hiding this comment.
弄个中文的就行了，debug 的例子可以不弄两个语言
doom-9-zz
force-pushed
the
feat(page-header)-support-rtl
branch
from
b85c13a to
7a0beac
Compare
No description provided.