Emit progress events in Node.js again #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602.
Basically, in some previous release tus-js-client lost the ability to emit progress events when used in Node.js with a data source other than a
fs.ReadStream. This was caused by changes in our internal logic for reading data from the sources.This PR fixes the problem by making sure that we also emit progress events if a Buffer is written to the writable stream for a HTTP request. The details are explained in the code.
The code itself is ready for a review, but I want to see if I can add a test for this, so we can avoid similar regressions in the future. EDIT: Test has been added.