Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IOS-compatibility): replacing events package by native EventTarge… #92

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Load-Ma
Copy link
Contributor

@Load-Ma Load-Ma commented Dec 8, 2024

The events package was not available in the iOS version of Obsidian, so I replaced it with the native EventTarget class. Here's what I did:

  • Created a new class, "CustomEventTarget," in the /modules folder.
  • Implemented all the methods used by the events package in the new CustomEventTarget class.
  • Now, the plugin has the same code as before to emit, listen to, and remove events, but it uses the new CustomEventTarget class instead of the "events" package.

Feel free to ask anything about the code or if I need to move the new CustomEventTarget class to another folder!

@turulix
Copy link
Owner

turulix commented Dec 8, 2024

Looks good so far, mind removing the .md files?

@turulix turulix mentioned this pull request Dec 8, 2024
@turulix turulix linked an issue Dec 8, 2024 that may be closed by this pull request
@Load-Ma
Copy link
Contributor Author

Load-Ma commented Dec 9, 2024

Looks good so far, mind removing the .md files?

Do you want me to remove all .md files ? or just some of them ?

@turulix
Copy link
Owner

turulix commented Dec 10, 2024

All of them, i dont see why they should be there. Or am i missing something?

@Load-Ma
Copy link
Contributor Author

Load-Ma commented Dec 10, 2024

No you're not, i think it has been generated when testing the plugin and i missed them.
I do it after work, i can't right now.

@Load-Ma
Copy link
Contributor Author

Load-Ma commented Dec 10, 2024

now it should be good

@turulix turulix merged commit 8828705 into turulix:master Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No index on iOS
2 participants