Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subfolder aren't being displayed on the TOC of the parent folder note #26

Closed
qazero opened this issue Apr 28, 2023 · 18 comments · Fixed by #34
Closed

Subfolder aren't being displayed on the TOC of the parent folder note #26

qazero opened this issue Apr 28, 2023 · 18 comments · Fixed by #34
Assignees
Labels
enhancement New feature or request

Comments

@qazero
Copy link

qazero commented Apr 28, 2023

Firstly, than you for creating this wonderful plugin, I am loving it!

I noticed that the TOC only lists notes within the same folder. But if I have a subfolder that contains additional notes, the parent TOC won't display any of these. Ideally it would be nice to be able to navigate all levels deep from the parent TOC. Would it be possible to implement this and have the plugin look recursively?

Thanks in advance for your consideration!

@turulix turulix added the enhancement New feature or request label Apr 28, 2023
@turulix
Copy link
Owner

turulix commented Apr 28, 2023

This is indeed on the todo list :)

@qazero
Copy link
Author

qazero commented Apr 28, 2023

Sweet! Glad to hear it. Any rough idea when you think the feature will release? Only reason I ask is so I can gauge whether or not I need to look at using something else in the interim or just wait.

@turulix
Copy link
Owner

turulix commented Apr 29, 2023

I'm not sure yet, but soon™

@turulix turulix self-assigned this Apr 29, 2023
turulix added a commit that referenced this issue Apr 29, 2023
@turulix
Copy link
Owner

turulix commented Apr 29, 2023

Just as a heads up, using : in a header seems to break the link, and i don't know why. Seems to be a obsidian thing tho. This is disabled by default, so you gotta enabled "Build IndexFiles Recursively" in the settings

@qazero
Copy link
Author

qazero commented Apr 29, 2023

Wow big thanks to you for the quick update. I'm excited to test out the new version but when I click on update in Obsidian it says Failed. Any ideas?

@qazero
Copy link
Author

qazero commented Apr 30, 2023

app.js:1 Error: Request failed, status 404
    at new t (app.js:1:717762)
    at Jw (app.js:1:717954)
    at app.js:1:718631
    at app.js:1:235836
    at Object.next (app.js:1:235941)
    at a (app.js:1:234680)
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
s @ app.js:1
Promise.then (async)
l @ app.js:1
(anonymous) @ app.js:1
v @ app.js:1
e.installPlugin @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
a @ app.js:1
Promise.then (async)
l @ app.js:1
(anonymous) @ app.js:1
v @ app.js:1
(anonymous) @ app.js:1```

@turulix
Copy link
Owner

turulix commented Apr 30, 2023

That dosn't look like an issue with the Plugin itself but more like Obsidian for some reason. Just tryed it in one of my vaults and it worked without a problem

@qazero
Copy link
Author

qazero commented Apr 30, 2023

Works now, must have been a network issue of some sort given the 404 I was getting before. Testing it out now, thanks!

@turulix
Copy link
Owner

turulix commented Apr 30, 2023

No problem :) Looking forward to your feedback!

@qazero
Copy link
Author

qazero commented Apr 30, 2023

Works great, thank you! Just a couple enhancements if possible:

  1. Ability to collapse parent bullet from TOC list if there are child bullet points. Make parent bullet point bold (symbolizes folder)

  2. Output to markdown list instead of code block to preserve more universal markdown format compatibility (can see Waypoint plugin for reference if it helps): https://github.com/IdreesInc/Waypoint/

  3. Ability to ignore creating folder note for certain folders.

@turulix
Copy link
Owner

turulix commented Apr 30, 2023

I saw that 3rd point being added xD

@turulix
Copy link
Owner

turulix commented Apr 30, 2023

#37 Should fix the first point. Well, partially. The bulletpoints are collapsable once i use the method stated in 2.

@turulix
Copy link
Owner

turulix commented Apr 30, 2023

#39 Fixes the 3rd point. I'l make a release once i implement 2.

@qazero
Copy link
Author

qazero commented May 4, 2023

I noticed there has been a new release (which I've updated to as well). I see that folders are now Bold thank you! Would it be possible to use the same default color scheme for the folders (blue) instead of white? Also, could you please add the option to underline folder as well?

Are the parent bullets supposed to be collapsible in this release (I wasn't able to collapse them) or is that still pending the on # 2 for an upcoming release? If it hasn't been rolled out yet then no worries, just wanted to make sure. :)

I see that you have implemented # 3 thank you!! :D

image

@turulix
Copy link
Owner

turulix commented May 4, 2023

Obsidian dosn't do the collapsing when its rendered via the current way, so this will be automatically a thing when the waypoint style rendering is implemented. Can't do anything about the color, as thats because the folder isn't a link in that case

@qazero
Copy link
Author

qazero commented May 4, 2023

Makes sense. Should I open a new Feature Request to track # 2 so I can follow it once it's released or do you already have an open issue for it?

Also, should I open a new FR for this too?

Would it be possible to use the same default color scheme for the folders (blue) instead of white? Also, could you please add the option to underline folder as well?

@turulix
Copy link
Owner

turulix commented May 4, 2023

Yes please, I don't think i can fix the second one but feel free to make a FR aswell for it :/

@qazero
Copy link
Author

qazero commented May 4, 2023

Done, thanks again for your efforts! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants