Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): use lld linker as suggested by ext-php-rs #4

Closed

Conversation

hamptokr
Copy link
Contributor

@hamptokr hamptokr commented Jul 9, 2024

Actions are failing due to link.exe errors. ext-php-rs actually has a note about the linker here: https://github.com/davidcole1340/ext-php-rs?tab=readme-ov-file#windows-requirements

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@darkterminal
Copy link
Collaborator

So quick! Dang it...

Comment on lines +10 to +11
linker = "rust-lld"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still error:
image

I am also add:

- name: Install Visual Studio Build Tools
        if: matrix.os == 'windows-2019'
        shell: pwsh
        run: |
          Invoke-RestMethod -Uri https://aka.ms/vs/17/release/vs_buildtools.exe -OutFile vs_buildtools.exe
          Start-Process -FilePath vs_buildtools.exe -ArgumentList "--add", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", "--add", "Microsoft.VisualStudio.Component.Windows10SDK.19041", "--norestart", "--passive", "--wait" -Wait -PassThru
          Remove-Item vs_buildtools.exe

@darkterminal
Copy link
Collaborator

Yes.. that's still give an error.

@darkterminal darkterminal added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 10, 2024
@darkterminal
Copy link
Collaborator

This PR is closed by #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants