-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update import paths, examples and docs with new module name #94
Conversation
Signed-off-by: Erik Westra <[email protected]>
Thanks @webstradev! |
Isn't this breaking existing users? |
If the previous module is still at the same address it won't break for them, it just means they won't be able to get newer versions from that address. |
Yes, but that's the price we pay for moving the repository to a different organization. The error message is pretty helpful, though:
@haaawk or are you thinking of some other solution to this? |
You could fork the commit before this was merged in and leave it at the old address as well i f that org is still in your control |
|
Would it not be better to keep the older version on the old URL and than add a message that this repository is continued at the new url. That way you have backwards compatibility. |
@webstradev We of course have control over the original organization, but I am hesitant to make fork there because we may end up driving people to use the old version for new applications. @haaawk I am not sure what leaving the old package name buys us because at some point in the future, we do want to move away from the |
Can we tag an older commit (pre this mr) with a version that people could then use. Not sure if it will actually fix the breaking issue because new users would probably still need to pin the use of thatt specific version but just an idea. |
@penberg I don't have the answer really. I guess we will see soon how many people are affected. |
Closes #92