Fixed bug described in issue #351 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed condition to mark position as a start of new entry. Before that # character was entries delimiter
|
Thanks for this. My apologies for the delay - I wasn't getting github emails. |
|
@turquoiseowl ok, what of the process for prerelease and how I can help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#351
Changed condition to mark position as a start of new entry. Before only # character was entries delimiter.
@turquoiseowl do you have any PO files examples which I can test locally after these changes?
Also, what do you think about code refactoring for POTranslationRepository.ParseTranslationFile method? I see benefits from doing so as ability to unit test file parsing operations and create separate class for it like POFileParser or something like that. Current ParseTranslationFile method is big and can be reduced.