Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Add table for workspace pipelines. #31

Merged
merged 36 commits into from
Feb 22, 2023
Merged

Add table for workspace pipelines. #31

merged 36 commits into from
Feb 22, 2023

Conversation

sidr0cker
Copy link
Contributor

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@sidr0cker sidr0cker self-assigned this Jan 11, 2023
@sidr0cker sidr0cker marked this pull request as ready for review February 16, 2023 07:27
@sidr0cker sidr0cker requested a review from misraved February 16, 2023 07:27
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddharthaturbot the changes look good but I have left a few minor suggestions.

The following changes need to be made across all the tables in the PR:

  • We typically follow the format plugin.Logger(ctx).Error("<table_name>.<function_name>", "query_error/connection_error", err) while adding trace logs to the tables. You might choose to add additional details wherever you feel necessary 👍.
  • Were you able to test response, err := plugin.RetryHydrate(ctx, d, h, getDetails, &plugin.RetryConfig{ShouldRetryError: shouldRetryError})? and does it work as per the expectation?

@@ -0,0 +1,71 @@
# Table: steampipecloud_process

Allows to track various activities performed on an identity in Steampipe Cloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont support optional quals in this table yet. The same has been added to the steampipecloud_workspace_process since that table supports it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for the second point - I have tested the retryhydrate stuff and it works as expected.

steampipecloud/table_steampipecloud_process.go Outdated Show resolved Hide resolved
steampipecloud/table_steampipecloud_workspace_pipeline.go Outdated Show resolved Hide resolved
steampipecloud/table_steampipecloud_workspace_pipeline.go Outdated Show resolved Hide resolved
steampipecloud/table_steampipecloud_workspace_pipeline.go Outdated Show resolved Hide resolved
steampipecloud/table_steampipecloud_workspace_pipeline.go Outdated Show resolved Hide resolved
steampipecloud/table_steampipecloud_workspace_pipeline.go Outdated Show resolved Hide resolved
@misraved misraved merged commit 21f58ed into main Feb 22, 2023
@misraved misraved deleted the workspace-pipelines branch February 22, 2023 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants