-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddharthaturbot the changes look good but I have left a few minor suggestions.
The following changes need to be made across all the tables in the PR:
- We typically follow the format
plugin.Logger(ctx).Error("<table_name>.<function_name>", "query_error/connection_error", err)
while adding trace logs to the tables. You might choose to add additional details wherever you feel necessary 👍. - Were you able to test
response, err := plugin.RetryHydrate(ctx, d, h, getDetails, &plugin.RetryConfig{ShouldRetryError: shouldRetryError})
? and does it work as per the expectation?
@@ -0,0 +1,71 @@ | |||
# Table: steampipecloud_process | |||
|
|||
Allows to track various activities performed on an identity in Steampipe Cloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a separate section highlighting the optional quals for this table as mentioned in https://github.com/turbot/steampipe-plugin-steampipecloud/pull/31/files#diff-1d6098679bced8287cde2de661f16aa150ee4a1566f349ad70b0206a00ad6c2bR27-R38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont support optional quals in this table yet. The same has been added to the steampipecloud_workspace_process since that table supports it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for the second point - I have tested the retryhydrate stuff and it works as expected.
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Example query results
Results