This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Add Database Log table to query database logs for a workspace. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LalitLab
suggested changes
Aug 18, 2022
steampipecloud/plugin.go
Outdated
| @@ -30,6 +30,7 @@ func Plugin(ctx context.Context) *plugin.Plugin { | |||
| "steampipecloud_workspace_connection": tableSteampipeCloudWorkspaceConnection(ctx), | |||
| "steampipecloud_workspace_mod": tableSteampipeCloudWorkspaceMod(ctx), | |||
| "steampipecloud_workspace_mod_variable": tableSteampipeCloudWorkspaceModVariable(ctx), | |||
| "steampipecloud_workspace_db_log": tableSteampipeCloudWorkspaceDbLog(ctx), | |||
There was a problem hiding this comment.
Suggested change
| "steampipecloud_workspace_db_log": tableSteampipeCloudWorkspaceDbLog(ctx), | |
| "steampipecloud_workspace_db_log": tableSteampipeCloudWorkspaceDBLog(ctx), |
cbruno10
suggested changes
Aug 19, 2022
| @@ -110,7 +110,7 @@ func listOrganizations(ctx context.Context, d *plugin.QueryData, h *plugin.Hydra | |||
| // execute list call | |||
| pagesLeft := true | |||
|
|
|||
| var resp openapi.ListActorOrgsResponse | |||
| var resp openapi.ListUserOrgsResponse | |||
There was a problem hiding this comment.
@siddharthaturbot Is this change related to the table that this PR is adding? If not, can you please describe why we're making this change?
There was a problem hiding this comment.
ListActorOrgsResponse is not used by the SDK anymore. Its necessary to add it in the PR or it wont compile.
| @@ -312,7 +308,6 @@ func getUserWorkspaceMod(ctx context.Context, d *plugin.QueryData, h *plugin.Hyd | |||
| response, err := plugin.RetryHydrate(ctx, d, h, getDetails, &plugin.RetryConfig{ShouldRetryError: shouldRetryError}) | |||
|
|
|||
| workspaceMod := response.(openapi.WorkspaceMod) | |||
| workspaceMod.Workspace = &openapi.Workspace{} | |||
There was a problem hiding this comment.
Is this change related to the table we're adding?
There was a problem hiding this comment.
Same as above, Workspace is not part of the struct anymore.
cbruno10
approved these changes
Aug 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example query results
Results