Skip to content

Commit

Permalink
Remove unnecessary table map func validation from plugin - this break…
Browse files Browse the repository at this point in the history
…s dynamic plugins when plugin manager is used. Closes #204
  • Loading branch information
kaidaguerre authored Nov 3, 2021
1 parent 0931117 commit 4f947c8
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions plugin/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ func (p *Plugin) SetConnectionConfig(connectionName, connectionConfigString stri
// 1) if a TableMapFunc factory function was provided by the plugin, call it
// 2) update tables to have a reference to the plugin
func (p *Plugin) initialiseTables(ctx context.Context) (err error) {
if p.TableMap != nil && p.TableMapFunc != nil {
return fmt.Errorf("plugin %s validation failed: plugin defines both TableMap and TableMapFunc", p.Name)
}

if p.TableMapFunc != nil {
// handle panic in factory function
defer func() {
Expand Down

0 comments on commit 4f947c8

Please sign in to comment.