Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status_of_primary and status_of_secondary to azure_storage_account table #605

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Add status_of_primary and status_of_secondary to azure_storage_account table #605

merged 3 commits into from
Apr 21, 2023

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Apr 17, 2023 •
edited
Loading

Add status_of_primary and status_of_secondary to azure_storage_account table

@pdecat pdecat changed the title main Add missing columns to some tables Apr 17, 2023
@misraved misraved self-requested a review April 17, 2023 20:10
misraved
misraved reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pdecat for adding the new columns 👍. Could you please add minor example queries in the table docs reflecting the usage of the new columns?

@pdecat pdecat marked this pull request as draft April 18, 2023 15:35
@pdecat pdecat changed the title Add missing columns to some tables Add status_of_primary and status_of_secondary to azure_storage_account table Apr 18, 2023
@pdecat pdecat marked this pull request as ready for review April 18, 2023 20:45
@pdecat pdecat requested a review from misraved April 18, 2023 20:57
@misraved misraved merged commit 0368fe1 into turbot:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbruno10 cbruno10 cbruno10 left review comments

@misraved misraved misraved approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdecat @cbruno10 @misraved