Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table azure_compute_virtual_machine_scale_set_vm closes #423 #425

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Add table azure_compute_virtual_machine_scale_set_vm closes #423 #425

merged 5 commits into from
Jan 5, 2022

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Dec 22, 2021

Integration test logs

Logs 
Terraform does not support the resource.

Example query results

Results

Basic info

select
  name,
  scale_set_name,
  instance_id,
  id,
  vm_id,
  region,
  resource_group
from
  azure_compute_virtual_machine_scale_set_vm;
+--------------------------------------+------------------------------------+-------------+---------------------------------------------------------------------------------------------------------------
| name                                 | scale_set_name                     | instance_id | id                                                                                                            
+--------------------------------------+------------------------------------+-------------+---------------------------------------------------------------------------------------------------------------
| test_0                               | test                               | 0           | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.Compute/virtu
| turbot-test-20201223-create-update_3 | turbot-test-20201223-create-update | 3           | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot-test-20201223-create-update/provider
| turbot-test-20201223-create-update_1 | turbot-test-20201223-create-update | 1           | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot-test-20201223-create-update/provider
+--------------------------------------+------------------------------------+-------------+---------------------------------------------------------------------------------------------------------------

List Standard tier scale set vms

select
  name,
  scale_set_name,
  id,
  sku_name,
  sku_tier
from
  azure_compute_virtual_machine_scale_set_vm
where
   sku_tier = 'Standard';
+--------------------------------------+------------------------------------+-----------------------------------------------------------------------------------------------------------------------------
| name                                 | scale_set_name                     | id                                                                                                                          
+--------------------------------------+------------------------------------+-----------------------------------------------------------------------------------------------------------------------------
| test_0                               | test                               | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.Compute/virtualMachineScale
| turbot-test-20201223-create-update_3 | turbot-test-20201223-create-update | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot-test-20201223-create-update/providers/Microsoft.Co
| turbot-test-20201223-create-update_1 | turbot-test-20201223-create-update | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot-test-20201223-create-update/providers/Microsoft.Co
+--------------------------------------+------------------------------------+-----------------------------------------------------------------------------------------------------------------------------

List all virtual machines under a specific scale set

select
  name,
  scale_set_name,
  id,
  sku_name,
  sku_tier
from
  azure_compute_virtual_machine_scale_set_vm
where 
  scale_set_name = 'turbot-test-20201223-create-update';
+--------------------------------------+------------------------------------+-----------------------------------------------------------------------------------------------------------------------------
| name                                 | scale_set_name                     | id                                                                                                                          
+--------------------------------------+------------------------------------+-----------------------------------------------------------------------------------------------------------------------------
| turbot-test-20201223-create-update_3 | turbot-test-20201223-create-update | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot-test-20201223-create-update/providers/Microsoft.Co
| turbot-test-20201223-create-update_1 | turbot-test-20201223-create-update | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot-test-20201223-create-update/providers/Microsoft.Co
+--------------------------------------+------------------------------------+-----------------------------------------------------------------------------------------------------------------------------

@ParthaI ParthaI linked an issue Dec 22, 2021 that may be closed by this pull request
Add table azure_compute_virtual_machine_scale_set_vm #423
Closed
bigdatasourav
bigdatasourav approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@bigdatasourav bigdatasourav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

misraved
misraved reviewed Dec 22, 2021
View reviewed changes
azure/table_azure_compute_virtual_machine_scale_set_vm.go Outdated
},
{
Name: "availability_set",
Description: "Specifies information about the availability set that the virtual machine should be assigned to. Virtual machines specified in the same availability set are allocated to different nodes to maximize availability. For more information about availability sets, see [Manage the availability of virtual machines](https://docs.microsoft.com/azure/virtual-machines/virtual-machines-windows-manage-availability?toc=%2fazure%2fvirtual-machines%2fwindows%2ftoc.json). <br><br> For more information on Azure planned maintenance, see [Planned maintenance for virtual machines in Azure](https://docs.microsoft.com/azure/virtual-machines/virtual-machines-windows-planned-maintenance?toc=%2fazure%2fvirtual-machines%2fwindows%2ftoc.json) <br><br> Currently, a VM can only be added to availability set at creation time. An existing VM cannot be added to an availability set.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the line breaks and make the description slightly concise?

misraved
misraved reviewed Dec 22, 2021
View reviewed changes
docs/tables/azure_compute_virtual_machine_scale_set_vm.md Outdated
azure_compute_virtual_machine_scale_set_vm;
```

### List Standard tier scale set vms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### List Standard tier scale set vms
### List Standard tier scale set virtual machines

misraved
misraved reviewed Dec 22, 2021
View reviewed changes
docs/tables/azure_compute_virtual_machine_scale_set_vm.md Outdated
scale_set_name = 'my_vm_scale';
```

### View Network Security Group Rules for a VM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### View Network Security Group Rules for a VM
### View Network Security Group Rules for a virtual machine

misraved
misraved reviewed Dec 22, 2021
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review if the VM acronym used in the descriptions can be updated to virtual machines.
Make changes wherever necessary

@rajlearner17 rajlearner17 mentioned this pull request Jan 4, 2022
Closed
@bigdatasourav bigdatasourav merged commit 89d9e9b into main Jan 5, 2022
@bigdatasourav bigdatasourav deleted the add-table-virtual_machine_scale_set_vm branch January 5, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved misraved left review comments

@bigdatasourav bigdatasourav bigdatasourav approved these changes

Assignees

@ParthaI ParthaI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add table azure_compute_virtual_machine_scale_set_vm
3 participants
@ParthaI @misraved @bigdatasourav