Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_config_delivery_channel table closes #2325 #2343

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

misraved
Copy link
Contributor

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
 select * from aws_config_delivery_channel
+---------+-----------------------------------------------------------------+----------------------------+---------------+----------------+------------------------------------------------->
| name    | arn                                                             | s3_bucket_name             | s3_key_prefix | s3_kms_key_arn | sns_topic_arn                                   >
+---------+-----------------------------------------------------------------+----------------------------+---------------+----------------+------------------------------------------------->
| default | arn:aws:config:ap-south-1:1111111111111111:delivery-channel/default | config-bucket-1111111111111111 | <null>        | <null>         | arn:aws:sns:ap-south-1:1111111111111111:config-topic>
| default | arn:aws:config:us-west-1:1111111111111111:delivery-channel/default  | config-bucket-1111111111111111 | <null>        | <null>         | <null>                                          >
| default | arn:aws:config:us-east-1:1111111111111111:delivery-channel/default  | config-bucket-1111111111111111 | <null>        | <null>         | <null>                                          >
| default | arn:aws:config:us-east-2:1111111111111111:delivery-channel/default  | config-bucket-1111111111111111 | <null>        | <null>         | <null>                                          >
+---------+-----------------------------------------------------------------+----------------------------+---------------+----------------+------------------------------------------------```
</details>

@misraved misraved requested a review from ParthaI November 26, 2024 06:27
@misraved misraved self-assigned this Nov 26, 2024
Copy link
Contributor

@ParthaI ParthaI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misraved. I have left a few review comments please take a look. Thanks!

aws/table_aws_config_delivery_channel.go Outdated Show resolved Hide resolved
aws/table_aws_config_delivery_channel.go Outdated Show resolved Hide resolved
aws/table_aws_config_delivery_channel.go Outdated Show resolved Hide resolved
aws/table_aws_config_delivery_channel.go Show resolved Hide resolved
aws/table_aws_config_delivery_channel.go Outdated Show resolved Hide resolved
@misraved misraved merged commit 3d2b869 into main Nov 29, 2024
1 check passed
@misraved misraved deleted the add-aws-config-delivery-channel-table branch November 29, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants