Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EPSS Score Column #2321

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dbermuehler
Copy link
Contributor

This PR adds the missing EPSS Score column to the aws_inspector2_finding table.

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@misraved misraved added the hacktoberfest-accepted This pull request has been accepted for Hacktoberfest label Oct 15, 2024
@misraved misraved requested a review from ParthaI October 15, 2024 19:40
@ParthaI
Copy link
Contributor

ParthaI commented Oct 16, 2024

Hi @dbermuehler, the changes look great to me. Could you please include an example query result in the PR description? The example should showcase the value of the epss_score column.

Here are a few example queries that would be helpful:

  • SELECT finding_account_id, resource_id, type, epss_score FROM aws_inspector2_finding; (without any query parameters)
  • SELECT resource_id, type, epss_score FROM aws_inspector2_finding WHERE epss_score >= <some value>; (using the >= operator)
  • SELECT resource_id, type, epss_score FROM aws_inspector2_finding WHERE epss_score <= <some value>; (using the <= operator)

Thanks!

@misraved misraved merged commit c9b8622 into turbot:main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This pull request has been accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants