Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamModeDetails column to Kinesis stream table #2320

Conversation

kaushikkishore
Copy link
Contributor

@kaushikkishore kaushikkishore commented Oct 14, 2024

First-time Contributor:

This is my first contribution to the Steampipe project, and I’m excited to collaborate with the team! Please feel free to provide any feedback or guidance on improvements. I’m happy to make any adjustments as needed. Thank you for reviewing my contribution!

Details

This PR introduces a new column, StreamModeDetails, in the aws/table_aws_kinesis_stream.go table. The purpose of this column is to provide essential information about the mode of Kinesis streams, allowing users to easily identify whether a stream is provisioned or on-demand.

Key Changes:

Added StreamModeDetails column to the Kinesis Stream table definition.
Updated logic to retrieve and display stream mode details.

Benefits:

Enhances the visibility of Kinesis stream configuration by indicating the stream mode.
Simplifies resource monitoring and management for users dealing with both provisioned and on-demand Kinesis streams.

Query example

image

@misraved misraved self-requested a review October 14, 2024 11:45
@misraved misraved added the hacktoberfest-accepted This pull request has been accepted for Hacktoberfest label Oct 14, 2024
@misraved misraved merged commit 9afd6f4 into turbot:main Oct 14, 2024
1 check passed
@kaushikkishore kaushikkishore deleted the feature/add-stream-mode-details-to-kinesis branch October 14, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This pull request has been accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants