Optimized the input parameter build code

turbot · Dec 16, 2024 · 42c229d · 42c229d
1 parent 0bd333d
commit 42c229d
Showing 1 changed file with 7 additions and 15 deletions.
diff --git a/aws/table_aws_costoptimizationhub_recommendation.go b/aws/table_aws_costoptimizationhub_recommendation.go
@@ -314,23 +314,9 @@ func buildCostOptimizationHubRecommendationInputFromQuals(quals plugin.KeyColumn
 	for _, columnName := range filterQuals {
 		if quals[columnName] != nil {
 			switch columnName {
-			case "implementation_effort":
-				value := getQualsValueByColumn(quals, columnName, "string")
-				param.ImplementationEfforts = []types.ImplementationEffort{types.ImplementationEffort(value.(string))}
-			case "action_type":
-				value := getQualsValueByColumn(quals, columnName, "string")
-				param.ActionTypes = []types.ActionType{types.ActionType(value.(string))}
-			case "current_resource_type", "recommended_resource_type":
-				value := getQualsValueByColumn(quals, columnName, "string")
-				param.ResourceTypes = []types.ResourceType{types.ResourceType(value.(string))}
 			case "restart_needed", "rollback_possible":
 				value := getQualsValueByColumn(quals, columnName, "boolean")
-				var val bool
-				if value.(string) == "true" {
-					val = true
-				} else {
-					val = false
-				}
+				val := value.(string) == "true"
 				if columnName == "restart_needed" {
 					param.RestartNeeded = &val
 				}
@@ -350,6 +336,12 @@ func buildCostOptimizationHubRecommendationInputFromQuals(quals plugin.KeyColumn
 					param.ResourceArns = []string{fmt.Sprint(value)}
 				case "resource_id":
 					param.ResourceIds = []string{fmt.Sprint(value)}
+				case "implementation_effort":
+					param.ImplementationEfforts = []types.ImplementationEffort{types.ImplementationEffort(value.(string))}
+				case "action_type":
+					param.ActionTypes = []types.ActionType{types.ActionType(value.(string))}
+				case "current_resource_type", "recommended_resource_type":
+					param.ResourceTypes = []types.ResourceType{types.ResourceType(value.(string))}
 				}
 			}
 		}