This repository has been archived by the owner on Jul 28, 2018. It is now read-only.
Don't clone data-turbolinks-permanent and :keep nodes #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhh
added a commit
that referenced
this pull request
Mar 7, 2015
Don't clone data-turbolinks-permanent and :keep nodes
|
@Thibaut I just discovered that due to this change, permanent nodes disappear from cached pages. I hit the back button and all the sections with |
|
Yeah, I think I noticed the same behaviour at my app. |
|
@reed @jtomaszewski I noticed some weird stuff around back/forward navigation too. I'll PR tests and a fix by the end of the week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #477
Tests pass in latest Firefox, Chrome, Safari and IE10.
cc @reed @dhh @kristianpd @jtomaszewski