Add tests for Policy-Management and BGPVPN. #14

Goutham-Pratapa · 2019-01-02T16:06:23Z

http://www.opencontrail.org/documentation/api/r5.0/contrail_openapi.html#policy-management-label
http://www.opencontrail.org/documentation/api/r5.0/contrail_openapi.html#bgpvpn-label

http://www.opencontrail.org/documentation/api/r5.0/contrail_openapi.html#policy-management-label http://www.opencontrail.org/documentation/api/r5.0/contrail_openapi.html#bgpvpn-label

Goutham-Pratapa

@SVilgelm can you please review this ?

SVilgelm · 2019-01-02T17:27:27Z

Again, you don't need to create new pull request, so we lost our conversation. You had to use push --force to update the old PR

SVilgelm

LGTM

aveeshek · 2019-01-10T09:34:52Z

Can you provide the test results and pylint report without any pylint rc, please?

Goutham-Pratapa · 2019-01-10T11:53:45Z

Here are the Pylint-results

(35_env) root@ubuntu:~# pylint /home/ubuntu/run/tungsten-tempest/tungsten_tempest_plugin/tests/api/contrail/test_bgpvpn.py

Your code has been rated at 10.00/10

(35_env) root@ubuntu:~# pylint /home/ubuntu/run/tungsten-tempest/tungsten_tempest_plugin/tests/api/contrail/test_policy_management.py

Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

Tempest-results:

admin
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_create_policy_management [6.218197s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_delete_policy_management [6.669735s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_list_policy_managements [5.397828s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_show_policy_management [5.394721s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_update_policy_management [5.244792s] ... ok

======
Totals

Ran: 5 tests in 28.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 28.9253 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:28.941050

{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_create_bgpvpns [6.451468s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_delete_bgpvpn [6.440947s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_list_bgpvpns [5.528035s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_show_bgpvpn [5.527011s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_update_bgpvpn [5.305421s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.5449 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.260100

admin_contrail

{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_create_bgpvpns [6.431468s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_delete_bgpvpn [6.450947s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_list_bgpvpns [5.527035s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_show_bgpvpn [5.528011s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_update_bgpvpn [5.307421s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.2449 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.260100

{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_create_policy_management [6.454020s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_delete_policy_management [6.346875s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_list_policy_managements [5.635676s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_show_policy_management [5.508522s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_update_policy_management [5.494641s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.4397 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.470934

admin_support
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_create_bgpvpns [6.351945s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_delete_bgpvpn [6.754163s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_list_bgpvpns [5.659587s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_show_bgpvpn [5.378873s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_update_bgpvpn [5.535969s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.6805 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.695315

{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_create_policy_management [6.741101s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_delete_policy_management [6.580997s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_list_policy_managements [5.496216s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_show_policy_management [5.450331s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_update_policy_management [5.414610s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.6833 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.706778

member

{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_create_bgpvpns [6.426032s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_delete_bgpvpn [6.841574s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_list_bgpvpns [5.449463s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_show_bgpvpn [5.703570s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_update_bgpvpn [5.036730s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.4574 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.470092

{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_create_policy_management [6.459113s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_delete_policy_management [6.537438s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_list_policy_managements [5.541407s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_show_policy_management [5.613213s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_update_policy_management [5.642811s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.7940 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.809052

snapshot_member
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_create_bgpvpns [6.451870s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_delete_bgpvpn [6.543311s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_list_bgpvpns [5.425310s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_show_bgpvpn [5.431354s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_update_bgpvpn [5.595536s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.4474 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.477456

{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_create_policy_management [6.666415s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_delete_policy_management [8.187840s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_list_policy_managements [5.253190s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_show_policy_management [5.412573s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_update_policy_management [5.569651s] ... ok

======
Totals

Ran: 5 tests in 31.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 31.0897 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:31.103346

Sriov_member

{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_create_policy_management [6.477028s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_delete_policy_management [6.546091s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_list_policy_managements [5.215769s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_show_policy_management [5.502997s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_update_policy_management [5.359199s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.1011 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.114304

{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_create_bgpvpns [7.889758s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_delete_bgpvpn [6.344267s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_list_bgpvpns [5.403473s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_show_bgpvpn [5.443681s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_update_bgpvpn [5.268566s] ... ok

======
Totals

Ran: 5 tests in 30.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 30.3497 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:30.368813

support_member

{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_create_bgpvpns [6.380822s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_delete_bgpvpn [6.660343s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_list_bgpvpns [5.437928s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_show_bgpvpn [5.236100s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_bgpvpn.BgpvpnTest.test_update_bgpvpn [5.391259s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.1065 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.122146

{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_create_policy_management [6.942435s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_delete_policy_management [6.477204s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_list_policy_managements [5.431814s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_show_policy_management [5.424164s] ... ok
{0} tungsten_tempest_plugin.tests.api.contrail.test_policy_management.PolicyManagementTest.test_update_policy_management [5.318827s] ... ok

======
Totals

Ran: 5 tests in 29.0000 sec.

Passed: 5
Skipped: 0
Expected Fail: 0
Unexpected Success: 0
Failed: 0
Sum of execute time for each test: 29.5944 sec.

==============
Worker Balance

Worker 0 (5 tests) => 0:00:29.611375

Thanks
Goutham Pratapa.

http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#service-object-label http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#tag-type-label

SVilgelm

Please, use from tempest.lib import decorators to avoid pep8 error or ping @aveeshek, he has a code to fix this problem.

SVilgelm · 2019-01-22T01:56:48Z

tungsten_tempest_plugin/tests/api/contrail/test_service_object.py

+
+    @rbac_rule_validation.action(service="Contrail",
+                                 rules=["list_service_objects"])
+    @decorators.idempotent_id('05458fa1-ba09-4772-91aa-ca06243b5f5e')


You use @decorators.idempotent_id here, but you imports from tempest.lib.decorators import idempotent_id on L20.
So there is not decorators module in the current scope.

Yea i have updated it thanks :)

SVilgelm · 2019-01-22T02:00:15Z

tungsten_tempest_plugin/tests/api/contrail/test_tag_type.py

+from patrole_tempest_plugin import rbac_rule_validation
+from tempest import config
+from tempest.lib.common.utils import data_utils
+from tempest.lib import decorators


http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#service-object-label http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#tag-type-label

…tempest

SVilgelm

LGTM

Add tests for Policy-Management and BGPVPN.

20c15d5

http://www.opencontrail.org/documentation/api/r5.0/contrail_openapi.html#policy-management-label http://www.opencontrail.org/documentation/api/r5.0/contrail_openapi.html#bgpvpn-label

Goutham-Pratapa commented Jan 2, 2019

View reviewed changes

SVilgelm approved these changes Jan 2, 2019

View reviewed changes

Update test_policy_management.py

4f92d29

Add tests for Tag_Type and Service_objects.

d356758

http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#service-object-label http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#tag-type-label

SVilgelm suggested changes Jan 22, 2019

View reviewed changes

Goutham Pratapa and others added 2 commits January 30, 2019 16:46

Add tests for Tag_Type and Service_objects.

5d68d02

http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#service-object-label http://www.opencontrail.org/documentation/api/r4.1/contrail_openapi.html#tag-type-label

Merge branch 'master' of https://github.com/Goutham-Pratapa/tungsten-…

966a2f2

…tempest

SVilgelm approved these changes Jan 31, 2019

View reviewed changes

aveeshek merged commit 9120a7a into tungstenfabric:master Feb 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for Policy-Management and BGPVPN. #14

Add tests for Policy-Management and BGPVPN. #14

Goutham-Pratapa commented Jan 2, 2019

Goutham-Pratapa left a comment

SVilgelm commented Jan 2, 2019 •

edited

Loading

SVilgelm left a comment

aveeshek commented Jan 10, 2019

Goutham-Pratapa commented Jan 10, 2019

SVilgelm left a comment

SVilgelm Jan 22, 2019

Goutham-Pratapa Jan 30, 2019

SVilgelm Jan 22, 2019

SVilgelm left a comment

Add tests for Policy-Management and BGPVPN. #14

Add tests for Policy-Management and BGPVPN. #14

Conversation

Goutham-Pratapa commented Jan 2, 2019

Goutham-Pratapa left a comment

Choose a reason for hiding this comment

SVilgelm commented Jan 2, 2019 • edited Loading

SVilgelm left a comment

Choose a reason for hiding this comment

aveeshek commented Jan 10, 2019

Goutham-Pratapa commented Jan 10, 2019

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

====== Totals

============== Worker Balance

SVilgelm left a comment

Choose a reason for hiding this comment

SVilgelm Jan 22, 2019

Choose a reason for hiding this comment

Goutham-Pratapa Jan 30, 2019

Choose a reason for hiding this comment

SVilgelm Jan 22, 2019

Choose a reason for hiding this comment

SVilgelm left a comment

Choose a reason for hiding this comment

SVilgelm commented Jan 2, 2019 •

edited

Loading

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance

======
Totals

==============
Worker Balance