fix: fix overriding device scale factor #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting viewport was overriding puppeteer
launchOptions
that set device scale factorhttps://github.com/tungs/timesnap/blob/master/index.js#L161
this does not allow improving image quality by setting
--launch-arguments="--device-scale-factor=2"
, or alternatively--launch-arguments="--force-device-scale-factor=2"
, as mentioned in #30This fixes it by extracting these options and adding them to config.viewport
You may consider also doing that for the rest of the properties
https://pptr.dev/#?product=Puppeteer&version=v5.0.0&show=api-pagesetviewportviewport
I believe this is an important setting for image quality, so you may also consider making it a cli arg