Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added PowerShell core 7.4.4 #192

Merged
merged 5 commits into from
Jul 27, 2024
Merged

added PowerShell core 7.4.4 #192

merged 5 commits into from
Jul 27, 2024

Conversation

Mohkam
Copy link
Contributor

@Mohkam Mohkam commented Jul 26, 2024

Feature PowerShell Core 7.4.4

@Mohkam Mohkam requested a review from tungbq as a code owner July 26, 2024 00:31
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution!🎉 Great first PR!
If you find this repository helpful, kindly consider showing your appreciation by giving it a star ⭐ Thanks! 💖

@tungbq
Copy link
Owner

tungbq commented Jul 26, 2024

Thank you @Mohkam. I would say that's very great work to add powershell into devops-toolkit.
The CI build is OK ✔️, we need to update some related scripts to check the version and sanity verify powershell:

Could you please check other tool implementation of these files and update simlar for Powershell? (I think it's pwsh command in these case)

Dockerfile Show resolved Hide resolved
@Mohkam Mohkam requested a review from tungbq July 26, 2024 11:10
@tungbq
Copy link
Owner

tungbq commented Jul 27, 2024

LGTM. Nice work @Mohkam

@tungbq tungbq merged commit 3b33b2c into tungbq:main Jul 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants