Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new interface #434

Merged
merged 43 commits into from
Jan 4, 2020
Merged

new interface #434

merged 43 commits into from
Jan 4, 2020

Conversation

xueruini
Copy link
Contributor

No description provided.

@zepinglee
Copy link
Contributor

先不要 merge,还需要改

thusetup.tex Outdated Show resolved Hide resolved
thusetup.tex Show resolved Hide resolved
main.tex Show resolved Hide resolved
thuthesis.dtx Show resolved Hide resolved
thuthesis.dtx Show resolved Hide resolved
thusetup.tex Outdated Show resolved Hide resolved
@xueruini
Copy link
Contributor Author

先不要 merge,还需要改

恩,这样好 comment,不会合并

@xueruini xueruini changed the title Interface [WIP] new interface Sep 23, 2019
@zepinglee
Copy link
Contributor

我之前为了方便比对,把你原来的 commits squash 到前面的 commits 了,所以你需要

git checkout interface;
git reset --hard origin/interface;
git checkout dev;
git reset --hard origin/dev;

之后 merge 到 master 前也还需要再 rebase 一下

@xueruini
Copy link
Contributor Author

xueruini commented Sep 23, 2019

我下午看到 dev 被强推了。我倒是觉得尽量本地 rebase,一旦推上来还是保持原样,哪怕乱一点都关系不大。所以我就合并了一下

你刚才强推的这个其实也不必,pull --rebase 不会有太多冲突,有也比较简单

实际上我在 dev 上提过一个小修改,清理了一个遗漏的 \changes

@zepinglee
Copy link
Contributor

这几个改动比较大,我需要仔细比对一下 tlg 文件的变化,最好保持整齐,所以一直在反复修改 “add unit test” 和 “new \thusetup interface” 这两个 commits;

那我们约定一下,

  1. master 分支禁止强推;
  2. dev branch 只在 merge 到 master 前由你来 rebase 整理 commits;
  3. topic branches 随意搞;

这个怎么样?

@xueruini
Copy link
Contributor Author

  • master 分支禁止强推;

没问题

  • dev branch 只在 merge 到 master 前由你来 rebase 整理 commits;

我对 history 的整洁度没那么在意,只要最后 PR OK 了,直接 merge 就行

  • topic branches 随意搞;

实际上我倾向于一旦推上来了,就尽量避免 force push,虽然目前同一个 feature 分支协作的概率不大。

@zepinglee
Copy link
Contributor

现在基本差不多了,只剩下本科英文模板,感觉工程量比较大,之后再去搞。

@xueruini 你可以 make pdf然后跟官方模板比对一下。

Copy link
Contributor Author

@xueruini xueruini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tlmgr update 到最新,newtx 冲突

(/usr/local/texlive/2019/texmf-dist/tex/latex/newpx/newpxmath.sty
`newpxmath' v1.401, 2019/10/02 Math macros based on pxfonts (msharpe)
(/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsmath.sty
For additional information on amsmath, use the `?' option.
(/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amstext.sty
(/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsgen.sty))
(/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsbsy.sty)
(/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsopn.sty))
(/usr/local/texlive/2019/texmf-dist/tex/generic/kastrup/binhex.tex)
(/usr/local/texlive/2019/texmf-dist/tex/latex/oberdiek/centernot.sty)

/usr/local/texlive/2019/texmf-dist/tex/latex/newpx/newpxmath.sty:494: LaTeX Err
or: Command `\lvert' already defined.

See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...

l.494 ...thopen}  {symbols}{106}{largesymbols}{12}

No pages of output.
Transcript written on thuthesis.log.
=== TeX engine is 'XeTeX'
Latexmk: Log file says no output from latex
Latexmk: For rule 'xelatex', no output was made
Latexmk: Errors, so I did not complete making targets
Collected error summary (may duplicate other messages):
  xelatex: Command for 'xelatex' gave return code 1
      Refer to 'thuthesis.log' for details
Latexmk: Use the -f option to force complete processing,
 unless error was exceeding maximum runs, or warnings treated as errors.
make: *** [thuthesis.pdf] Error 12

ctex 加载顺序调整一下就 OK 了。应该是 ctex 加载的某个包更新后定义了。这种最烦人了

@zepinglee
Copy link
Contributor

tlmgr update 到最新,newtx 冲突

ctex 加载顺序调整一下就 OK 了。应该是 ctex 加载的某个包更新后定义了。这种最烦人了

\RequirePackage{newpxtext} \RequirePackage{newpxmath} 放到 \RequirePackage[UTF8,scheme=chinese]{ctex} 前面,西文字体就变成 latin modern 了

@zepinglee
Copy link
Contributor

建议放弃 newtx/newpx,感觉这套 nfss 要跟 fonspec 兼容有太多坑了

@xueruini
Copy link
Contributor Author

xueruini commented Oct 8, 2019

看起来是 amsmath 的更新所致

/usr/local/texlive/2019/texmf-dist/tex/latex/newpx/newpxmath.sty:\DeclareMathDelimiter{\lvert} {\mathopen}  {symbols}{106}{largesymbols}{12}
/usr/local/texlive/2019/texmf-dist/tex/latex/newpx/newpxmath.sty:\re@DeclareMathSymbol{\lvertneqq}{\mathrel}{AMSm}{0}
/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsmath.sty:  \xdef\lvert{\delimiter\number\@tempcnta\space }
/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsmath.sty:  \ifx\@@undefined\lvert
/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsmath.sty:    \DeclareMathDelimiter{\lvert}
/usr/local/texlive/2019/texmf-dist/tex/latex/amsmath/amsmath.sty:\newenvironment{vmatrix}{\left\lvert\env@matrix}{\endmatrix\right\rvert}

去掉吧,没啥必须要留的原因

@zepinglee
Copy link
Contributor

去掉吧,没啥必须要留的原因

我记得以前模板转到 unicode-math 时保留了文档的 newpx 是因为它的等宽体比较好看,所以换成 Palatino + Helvetica + Menlo 怎么样?

thuthesis.dtx Outdated Show resolved Hide resolved
thuthesis.dtx Show resolved Hide resolved
@xueruini
Copy link
Contributor Author

我记得以前模板转到 unicode-math 时保留了文档的 newpx 是因为它的等宽体比较好看,所以换成 Palatino + Helvetica + Menlo 怎么样?

newpx 是文档里的配置,其实无所谓。按照这里分析 ElegantLaTeX/ElegantBook#59 (comment) newpx 估计很快就要改过来

@xueruini
Copy link
Contributor Author

日期和正文感觉挤在一起了

image

@zepinglee
Copy link
Contributor

zepinglee commented Dec 28, 2019 via email

@xueruini
Copy link
Contributor Author

Word 示例里就这么点空间啊

ok,不记得了

@xueruini
Copy link
Contributor Author

Word 示例里就这么点空间啊

这是修改前后的效果比对,感觉 geometry 变化不小

image

@zepinglee
Copy link
Contributor

刚发现用邮件回复的图片显示不出来……

Word 示例里确实就这么点空间:

Screen Shot 2019-12-28 at 3 58 19 PM

@xueruini
Copy link
Contributor Author

刚才发现专业名字的样式变了,新的里面多了一行 in

@zepinglee
Copy link
Contributor

zepinglee commented Dec 29, 2019 via email

@zepinglee
Copy link
Contributor

你可以 make savepdf,然后把 testfiles/01-cover/*.pdf 跟学校的 word 模板去比对

@zepinglee
Copy link
Contributor

我印象中,博士/硕士/学术型/专业型的 layout 有细微区别

@zepinglee
Copy link
Contributor

两个问题:

  1. 237b44b 的本意是允许在导言区中设置 \thusetup{degree=xxx},但是这样大大增加了代码的复杂度,而且容易造成 bug,建议回滚这个 commit;

  2. 本科生英语专业要求的“致谢”是“ACKNOWLEDGEMENTS”,我觉得不妨整个模板统一使用英式拼法。

thuthesis.dtx Show resolved Hide resolved
Copy link
Contributor Author

@xueruini xueruini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

xueruini and others added 5 commits January 3, 2020 09:52
The WORD version does not provide proper typesetting for joint supervisors.
Let's just remove this and fix later if there is official instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants