optionally make vlan name optional #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean to include the metrics reporter code in there? |
|
Nope sorry. rebased and fixed |
bmatheny
added a commit
that referenced
this pull request
Jun 7, 2013
optionally make vlan name optional
|
If you can update the docs too, that would be awesome. Thanks Chris! |
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
optionally make vlan name optional
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
optionally make vlan name optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got some fancy new switches that -- no matter how much we fittled with them -- would not convince lldp that they had a name/description in addition to an id.
Suffers from the tests not really working reliably per #71