If we have a dropdown in the UI, do an exact search #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theoretically the previous behavior would not work if one value was a substring of the other. In practice it also would fail to find any results for some odd combination of edge cases, for example "Dell Inc." should handle tumblr#78
|
Agree this makes sense. |
bmatheny
added a commit
that referenced
this pull request
Apr 12, 2013
If we have a dropdown in the UI, do an exact search
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
If we have a dropdown in the UI, do an exact search
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
If we have a dropdown in the UI, do an exact search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically the previous behavior would not work if one value was a
substring of the other. In practice it also would fail to find any
results for some odd combination of edge cases, for example "Dell
Inc."
should handle #78