Update docs with new classification json example #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
its odd that all the details on the classifier live in the configuration section. Where do you think it would be more useful? I feel like there should be some explicit callouts in the docs saying what to expect back from the API when an asset is classified. @michaeljs1990 |
roymarantz
approved these changes
May 9, 2017
byxorna
approved these changes
May 18, 2017
|
🎂 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested it out locally made sure everything ran with
bundle exec rake serve. I looked around to make sure no other docs need updating but this was the only place I found that looks like it would benefit from additional documentation.