Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPMI Pools Docs #533

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Add IPMI Pools Docs #533

merged 1 commit into from
Apr 7, 2017

Conversation

michaeljs1990
Copy link
Contributor

@michaeljs1990 michaeljs1990 commented Mar 23, 2017 •
edited
Loading

Adds documentation for the /api/ipmi/pools endpoint.

Closes #515

@michaeljs1990 michaeljs1990 mentioned this pull request Mar 23, 2017
Merged
2 tasks
@roymarantz
Copy link
Contributor

👍

byxorna
byxorna approved these changes Mar 25, 2017
View reviewed changes
Copy link
Contributor

@byxorna byxorna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We dont have Travis hooked up to run rake and make sure it builds; if you tested locally, lgtm!

@michaeljs1990
Copy link
Contributor Author

I wasn't sure how to test with rake but I did jekyll build && jekyll serve to make sure everything still worked.

@byxorna byxorna merged commit ffb3f3a into tumblr:gh-pages Apr 7, 2017
@michaeljs1990 michaeljs1990 deleted the gh-pages branch April 8, 2017 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byxorna byxorna byxorna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeljs1990 @roymarantz @byxorna