Collins-shell fix dependencies #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| s.homepage = "https://github.com/tumblr/collins/tree/master/support/ruby/collins-shell" | ||
| s.licenses = ["APL 2.0"] | ||
| s.require_paths = ["lib"] | ||
| s.rubygems_version = "1.8.23" |
There was a problem hiding this comment.
Docs say that this should never be set by hand, so I deleted it
http://guides.rubygems.org/specification-reference/#rubygems_version
|
🚅 LGTM |
added 2 commits
February 3, 2016 12:44
… remove rubygems-update dependency
william-richard
force-pushed
the
will-collins-ruby-no-rubygems-update-dependencies
branch
from
8b23188 to
7d02da1
Compare
|
👍 |
|
The scala tests failed, but all the ruby tests passed, so this is safe to go out. |
william-richard
added a commit
that referenced
this pull request
Feb 3, 2016
…ate-dependencies Collins-shell fix dependencies
william-richard
deleted the
will-collins-ruby-no-rubygems-update-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes here:
jewlerandrubygems-updatedependencies@tumblr/collins