Remove use of async result during asset cancel request #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove deprecated API AsyncResult and replace with Action. async when cancelling an asset.
|
@maddalab can you write some tests for this, maybe stub out the softlayer stuff? Looks simple enough, but I'd feel better if we made a habit of adding tests, especially where we have no good way to verify functionality |
|
I added a note in the issue around replacing softlayer api with jclouds to add tests. Since we plan to do that for the next release and I need this change in a sequence of steps to implement ipv6 ipam, going to go ahead and merge. |
yl3w
added a commit
that referenced
this pull request
Jun 14, 2015
Remove use of async result during asset cancel request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove deprecated API AsyncResult and replace with
Action. async when canceling an asset.
I tested intake and provisioning, however cancel itself requires softlayer and the particular change has not been tested. Given the change, I'm confident it is ok.
@byxorna @Primer42 @defect @roymarantz