Gabe monitoring plugin #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| protected def formatUrl(asset: AssetView) = | ||
| GenericFrameConfig.urlTemplate.format(asset.getHostnameMetaValue.get) |
There was a problem hiding this comment.
asset.getHostnameMetaValue.map(GFC.urlTemplate.formate) and similarly up the call chain and everything will fall into place not requiring the Some/None explicitness in getContent
There was a problem hiding this comment.
I converted those methods to options, but the else None is still required in getContent, because we need to test if the asset is monitorable still. Update incoming
|
Outside of the questions where I did not understand some of the choices this is lgtm. Also feel free to merge and we can revisit the questions in a second iteration |
|
@byxorna nice work =) |
|
@dallasmarlow tyty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a monitoring namespace with a GenericFrame plugin that can frame in a given url, parameterized by hostname. This will allow arbitrary monitoring systems to be integrated into collins, for great justice. I was going to ideally have the url be parameterized like the callbacks are, with
<tag>or<arbitrary_attribute>, but couldnt wrap my head around the craziness that is the Decorator being used in the callback module.@dallasmarlow @Primer42 @maddalab RFR