add some fields to asset_meta that are useful #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
lgtm, but maybe put something in the pool description about asset groups not related to roles? |
|
@dallasmarlow agreed, that needs clarification. I just updated the pull. How do the descriptions look now? |
|
LGTM |
|
🍜 |
byxorna
added a commit
that referenced
this pull request
Aug 20, 2014
add some fields to asset_meta that are useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maddalab @Primer42 This will populate the asset_meta table with some useful fields that are missing from the default install. new asset_meta values inserted via API have priority -1, which means they are totally excluded from the search page. This isnt documented anywhere unfortunately :(
This will provide a bit nicer out of the box experience for new users...