Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gabe tag decorators #167

Merged
merged 3 commits into from
Jun 16, 2014
Merged

Gabe tag decorators #167

merged 3 commits into from
Jun 16, 2014

Conversation

byxorna
Copy link
Contributor

@byxorna byxorna commented Jun 14, 2014

Add docs for tag decorators

@byxorna
Copy link
Contributor Author

byxorna commented Jun 14, 2014

@joshrabinowitz @maddalab @Primer42

@william-richard
Copy link
Contributor

@byxorna - there's something broken on this branch. When I try to build and host it locally, it fails. Not quite sure what, as you didn't make super big changes, but somethings up.

@byxorna
Copy link
Contributor Author

byxorna commented Jun 16, 2014

@Primer42 Is it this? Your site is using Maruku, the default Markdown interpreter. Maruku is now obsolete and may cause builds to fail for sites with invalid Markdown or HTML. See https://help.github.com/articles/migrating-your-pages-site-from-maruku for more information on upgrading to a newer Markdown interpreter.

I just started getting this as well.

@william-richard
Copy link
Contributor

@byxorna - nope, when I tried to run jekyll on your branch, it built and didn't give any warnings, but wouldn't let me access it from my local host. I saw hat same Maruku error when I ran on the gh-pages branch, but not on this branch. I'll play with it a bit more now.

@william-richard
Copy link
Contributor

@byxorna - don't mind me, I just didn't actually check out your branch.
LGTM 👍 🌳 🎉

byxorna pushed a commit that referenced this pull request Jun 16, 2014
@byxorna byxorna merged commit cc4f364 into tumblr:gh-pages Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants