-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
startAddress in ipmi.conf not being respected. #428
Comments
Hi @davidblum - I've taken a quick look at this - not sure yet what is going on, but I have a few ideas. Which version of collins are you currently running? |
@Primer42 Thanks for the quick reply! We are running the most current version, 1.3.0. Cloned from your repo this AM. |
@davidblum Sorry - did you use the released version of 1.3.0 (https://github.com/tumblr/collins/releases/tag/v1.3.0) or did you clone the current master? |
@Primer42 Ah, I see what you mean. Cloned from master this am. |
Hmmm ok. I have a few guesses about what may be going on, but I'm not totally sure. I'll keep digging - the IPMI address handling is trying to be a special case of the general IP address allocation, so I'm guessing that somewhere along the way something is getting dropped. |
Sounds good. Let me know what additional information I can provide or anything I can do Thanks very much for looking into it. On Monday, March 21, 2016, William Richard [email protected] wrote:
David Blum |
Did you make that change recently, i.e. have you allocated ip addresses prior to setting a start address? |
We have used the start address feature with pools successful in the past. We have only recently attempted implementing and using the ipmi feature. On Monday, March 21, 2016, Bhaskar Maddala [email protected] wrote:
David Blum |
so there are some IPMI addresses allocated current that are prior to the start address because that wasn't enforced initially, correct? |
That is correct. On Monday, March 21, 2016, Bhaskar Maddala [email protected] wrote:
David Blum |
@Primer42 Will, I spent all of 15-30 s on it, but I think that is the bug. |
@maddalab Any update on bug fix? |
I don't spend any time on Collins as I did as I no longer work at Tumblr. But I'll be happy to check it out when I get some time, don't want to be repeating work the someone at Tumblr might be doing. |
@maddalab Ah understood. Thanks for chiming in to narrow down the issue. @Primer42 Are you currently digging into the issue? |
@davidblum - I've been poking around at this, but I haven't made a lot of progress yet - I'm happy to write a fix once someone finds the bug, I just haven't had a chance to reproduce or figure out what the bug is yet. |
@Primer42 - understood. From our side, we have been allocating IPMI addresses to newly created assets. Recently we added the startAddress function, and collins continues to hand out IP's in the same place / range as before. It appears that the function responsible for identifying the minimum address in the range is not taking into account the startAddress. Does this help narrow down the issue? I can list the steps to recreate it as well if that would be beneficial. |
FWIW i have replicated this yesterday. I created a new collins instance, wiht ipmi start address |
@byxorna That is the exact behavior we are seeing. Glad you were able to replicate. |
so, confirms what I said initially was the issue, when I looked then it was simply switching a case statement around or adding an additional guard. |
@maddalab Is it possible for you to point us to this part of the code so we can attempt to implement you suggestions? |
@davidblum You want to take a stab at it. I think the change goes here. I'll try it during the weekend, sorry don't have time before then |
@maddalab Been poking around, no luck so far. How are things on your end? Did you find any time to test this weekend? |
@davidblum - thanks for finding that bug - have you been able to confirm that this is fixed? |
@Primer42 Just got a local instance running with all the new code, everything is testing well. I would consider this issue resolved. I'll close this bug now. |
When defining the IPMI start address in
/usr/local/collins/conf/ipmi.conf
as illustrated above, we create an asset via api call. The IPMI IP address assigned is one within the specified network range, but much lower than the explicitly stated startAddress.The text was updated successfully, but these errors were encountered: