Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate cpp output #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Generate cpp output #5

wants to merge 5 commits into from

Conversation

b4l
Copy link
Member

@b4l b4l commented Nov 21, 2022

Also deletes index.html as this should be provided on the referring side. See https://github.com/tum-bgd/webpage/pull/11

@b4l b4l requested a review from mwernerds November 21, 2022 21:38
Copy link
Contributor

@mwernerds mwernerds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I fear that the cpp part will very soon take too long to regenerate. In addition, it might depend on certain hardware features being available. I would completely remove the build phase from the Makefiles (e.g., all conversion from md.in to md) and check in the md into the book instead. Then, we can create a second Makefile for the CPP examples that updates local versions of the files (e.g., in the cpp folder) and make merge or similar to copy them into the web tree (where they would be commited like non-autogenerated files).

What do you think?

@b4l
Copy link
Member Author

b4l commented Nov 22, 2022

@mwernerds this sound good to me, pushed some changes in this direction.

@b4l b4l requested a review from mwernerds November 23, 2022 14:41
@b4l
Copy link
Member Author

b4l commented Jan 11, 2023

@mwernerds I resolved the merge conflicts so feel free to merge or close this pr if it is obsolete by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants