web/timeline: use blurhash before image loaded and for spoilers #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumner Evans <[email protected]>
Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
force-pushed
the
blurhash-and-image-spoilers
branch
from
b282c94 to
b31c92d
Compare
tulir
reviewed
Dec 1, 2024
| const blurhash = content.info ? content.info["xyz.amorgan.blurhash"] : undefined | ||
| const isSpoiler = content["m.content_warning"]?.type === "m.spoiler" || | ||
| content["town.robin.msc3725.content_warning"]?.type === "town.robin.msc3725.spoiler" | ||
| const showPlaceholder = (blurhash && !loaded) || (isSpoiler && !spoilerShowing) |
There was a problem hiding this comment.
Not sure if this is the correct place, seems like it should be applied to all media instead of just images
| @@ -23,18 +24,65 @@ import DownloadIcon from "@/icons/download.svg?react" | |||
| export const useMediaContent = ( | |||
| content: MediaMessageEventContent, evtType: EventType, containerSize?: ImageContainerSize, | |||
| ): [React.ReactElement | null, string, CSSProperties] => { | |||
| const imgEl = React.useRef<HTMLImageElement>(null) | |||
There was a problem hiding this comment.
Hooks should be imported individually instead of using React.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for rendering MSC2448 blurhashes and adds partial support for MSC3725 (content warnings, spoilers).
During image load, the blurhash (if present) is shown instead of the image until the image has been loaded.
Additionally, if it is a spoiler, then it will show up like this (using the blurhash):
then, on click
I couldn't figure out how to include blurhash exactly correctly. There were some dependency things that couldn't be resolved. React something something