Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades : Bootstrap UI+some css, python, django, some code cleanup #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GhalyahFA
Copy link

Thank you for this important project! Here is my attempt at a contribution :)

Before:
Screen Shot 2019-10-20 at 12 21 55 AM


After:
Screen Shot 2019-10-21 at 1 59 12 AM


Screen Shot 2019-10-21 at 1 59 22 AM


Screen Shot 2019-10-21 at 2 16 11 AM


Screen Shot 2019-10-21 at 2 15 53 AM

Pending : had an issue while trying to create the profile after migrating to the newer version of django- user is created but not the profile.. What would you think about using a signal to create a profile for each user?

@tulikavijay
Copy link
Owner

tulikavijay commented Oct 21, 2019

Hi @GhalyahF! i see you've made a lot of changes in the local-dev. The thing is that the local-dev is lagging in comparison with the master branch so for the time being i recommend you work with the master branch for UI changes(until i review your PR, it will take some time.) I have removed the command which specifies switching to local-dev, from the READme.
Also for you UI, i like what you've done with the login and register page. And i appreciate you designing a logo. But i would like to keep the navbar black and would like some time to think about the changes in the home page(the icons and the buttons)
Anyhow, Great work! Thanks!

@tulikavijay
Copy link
Owner

you can also work with docker. The new commit has made installation very easy.

@GhalyahFA
Copy link
Author

GhalyahFA commented Oct 21, 2019

Thank you again for this project. Great, I will check out the new commit! Just so you know I initially changed the navbar color so it would match with the icons you have, and grouped the icons because the features and services sectiond were very similar (less scrolling for use). The logo is just a temporary one from the icons8 site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants