Use https links #91
Merged
Use https links #91
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2018 11:47
|
Danger run resulted in 2 markdowns and 1 message; to find out more, see the checks page. Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 183 183
Lines 6341 6341
=======================================
Hits 5376 5376
Misses 965 965Continue to review full report at Codecov.
|
dcordero
reviewed
Aug 17, 2018
| @@ -4,7 +4,7 @@ public class Constants { | |||
| public static let versionFileName = ".tuist-version" | |||
| public static let binFolderName = ".tuist-bin" | |||
| public static let binName = "tuist" | |||
| public static let gitRepositorySSH = "git@github.com:tuist/tuist.git" | |||
| public static let gitRepositorySSH = "https://github.com/tuist/tuist.git" | |||
There was a problem hiding this comment.
Now that it is not longer containing a SSH url, this variable might be refactored to avoid including SSH on its name. I think something as gitRepositoryURL or similar might make sense.
There was a problem hiding this comment.
You are right. I'll update it. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88
Short description 📝
As @dcordero pointed out, GitHub encourages using https links instead of ssh's.
Solution 📦
Replace ssh links with the https version of them.