Prevent embedding static frameworks #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves tuist#454 - All `FrameworkNodes` (i.e. prebuilt frameworks) were being embedded regardless of their linkage - This check was redundant as there was a more general check for `PrecompiledNode` which happens to be the super class of `FrameworkNode` which took into account the framework linkage - To resolve this issue it was suffice to remove the redundant check Test Plan: - Generate `fixtures/ios_app_with_static_frameworks` via running `tuist generate` - Verify the generated project doesn't embed `PrebuiltStaticFramework` - Verify the generated project builds successfully
kwridan
commented
Aug 29, 2019
| @@ -309,15 +309,6 @@ class Graph: Graphing { | |||
|
|
|||
| references.append(contentsOf: otherTargetFrameworks) | |||
|
|
|||
| /// Pre-built frameworks | |||
There was a problem hiding this comment.
Line 299 takes care of embedding pre-compiled nodes (which include FrameworkNode) while checking their linkage (dynamic vs static)
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
=========================================
- Coverage 92.6% 92.6% -0.01%
=========================================
Files 347 347
Lines 17799 17815 +16
=========================================
+ Hits 16483 16497 +14
- Misses 1316 1318 +2
Continue to review full report at Codecov.
|
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #454
Short description 📝
Precompiled static frameworks were being embedded when generating projects.
Solution 📦
Notes 📝:
FrameworkNodes(i.e. prebuilt frameworks) were being embedded regardless of their linkagePrecompiledNodewhich happens to be the super class ofFrameworkNodewhich took into account the framework linkageImplementation 👩💻👨💻
Test Plan 🛠:
fixtures/ios_app_with_static_frameworksvia runningtuist generatePrebuiltStaticFramework