fix: Remove default support for MacCatalyst in Framework projects #4134
Conversation
|
@allcontributors add @TheInkedEngineer as contributor for code |
|
I've put up a pull request to add @TheInkedEngineer! 🎉 |
| @@ -8,6 +8,8 @@ Please, check out guidelines: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| - Use GitHub tags (via `git ls-remote`) to determine the latest Tuist version when installing/updating Tuist [#3985](https://github.com/tuist/tuist/pull/3985) by [@ezraberch](https://github.com/ezraberch) | |||
|
|
|||
| - Remove default MacCatalyst support when framework deployment target is set to iOS and/or iPad [#4134](https://github.com/tuist/tuist/pull/4134) by [@TheInkedEngineer](https://github.com/TheInkedEngineer) | |||
There was a problem hiding this comment.
Not sure why I see this old changelog here 🤔
For example, if you see on main, there should be many more entries in Next, and last release should be 2.7.2 🤷♂️
There was a problem hiding this comment.
I branched from main, should've I have branched from somewhere else @danyf90 ?
I can rebase
There was a problem hiding this comment.
nope, branch is fine 🤷
|
To fix linting errors: |
I can't access the Slack thread without a custom email. How can I enable Catalyst support in my dependencies? |
Resolves #4133
Request for comments document (if applies):
Short description 📝
After a short discussion on slack it was agreed then when the deployment target is explicitly specified to iOS and/or iPad, framework projects should not support the default behaviour of Xcode of including Mac Catalyst by default.
How to test the changes locally 🧐
A unit test has been added to make sure the modifications are properly working.
Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.TuistGraph.Target, theConstants.cacheVersionhas been updated.