Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env-version] added version command with envversion #399

Merged
merged 4 commits into from
Jun 8, 2019

Conversation

ollieatkinson
Copy link
Collaborator

@ollieatkinson ollieatkinson commented Jun 7, 2019

Resolves #383

Short description 📝

tuistenv does not report it's version which makes it hard to determine which version clients are on when bugs are raised.

Solution 📦

add envversion command to tuist so that it's easy to identify the version

@ollieatkinson ollieatkinson requested a review from a team June 7, 2019 20:44
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #399 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   92.29%   92.13%   -0.16%     
==========================================
  Files         291      292       +1     
  Lines       14711    14623      -88     
==========================================
- Hits        13577    13473     -104     
- Misses       1134     1150      +16
Impacted Files Coverage Δ
Sources/TuistEnvKit/Commands/CommandRegistry.swift 70.45% <0%> (-1.64%) ⬇️
Sources/TuistEnvKit/Commands/VersionCommand.swift 0% <0%> (ø)
Sources/TuistKit/Embed/XcodeBuild.swift 18.6% <0%> (-15.44%) ⬇️
Sources/TuistCoreTesting/Utils/MockSystem.swift 81.66% <0%> (-5%) ⬇️
Sources/TuistKit/Embed/FrameworkEmbedder.swift 79.22% <0%> (-3.01%) ⬇️
Sources/TuistGenerator/Graph/Graph.swift 95.31% <0%> (-0.43%) ⬇️
...stGenerator/Settings/DefaultSettingsProvider.swift 100% <0%> (ø) ⬆️
...rTests/Settings/DefaultSettingsProviderTests.swift 100% <0%> (ø) ⬆️
Sources/TuistGenerator/Models/Settings.swift 100% <0%> (ø) ⬆️
...s/TuistKitTests/Embed/FrameworkEmbedderTests.swift 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f67d8...1cf543a. Read the comment docs.

@tuistbot
Copy link
Contributor

tuistbot commented Jun 7, 2019

1 Warning
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

@ollieatkinson ollieatkinson merged commit fdbb740 into master Jun 8, 2019
@ollieatkinson ollieatkinson deleted the env-version branch June 8, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a version number to tuistenv
3 participants